Skip to content

chore(middleware-sdk-transcribe-streaming): remove unused yarn build before test#3250

Merged
trivikr merged 1 commit intoaws:mainfrom
trivikr:remove-unused-yarn-build
Jan 25, 2022
Merged

chore(middleware-sdk-transcribe-streaming): remove unused yarn build before test#3250
trivikr merged 1 commit intoaws:mainfrom
trivikr:remove-unused-yarn-build

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jan 25, 2022

Issue

Refs: #3248

Description

Removes unused yarn build before test, as it's no longer required.
We use ts-jest to run jest tests without compiling them to TypeScript.

Testing

Verified that yarn test succeeds without building middleware-sdk-transcribe-streaming package:

$ yarn test
yarn run v1.22.17
$ jest --passWithNoTests
 PASS  src/middleware-endpoint.spec.ts
 PASS  src/signer.spec.ts
 PASS  src/websocket-handler.spec.ts

Test Suites: 3 passed, 3 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        4.395 s
Ran all test suites.
Done in 5.46s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 25, 2022 20:15
@trivikr trivikr merged commit 0e95666 into aws:main Jan 25, 2022
@trivikr trivikr deleted the remove-unused-yarn-build branch January 25, 2022 21:04
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants