Skip to content

chore(deps-dev): bump jest to v27 #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

chore(deps-dev): bump jest to v27 #3127

wants to merge 16 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 4, 2022

Issue

Fixes: #2868
Replaces: #2869

Description

Bumps jest to v27

Testing

CI

Additional Context

This PR will be made ready after #3126 is merged.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 4, 2022 00:41
@trivikr trivikr marked this pull request as draft January 4, 2022 00:41
@trivikr trivikr changed the base branch from main to remove-jest-from-packages January 4, 2022 00:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #3127 (317aa61) into remove-jest-from-packages (d133ae3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           remove-jest-from-packages    #3127   +/-   ##
==========================================================
  Coverage                      75.18%   75.19%           
==========================================================
  Files                            474      474           
  Lines                          20721    20721           
  Branches                        4755     4755           
==========================================================
+ Hits                           15580    15581    +1     
+ Misses                          5141     5140    -1     
Impacted Files Coverage Δ
...ages/middleware-sdk-s3/src/throw-200-exceptions.ts 93.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d133ae3...317aa61. Read the comment docs.

trivikr added 16 commits January 4, 2022 14:42
async-await doesn't work with done callbacks in Jest v27
Refs: jestjs/jest#11404
Jest docs: jestjs.io/docs/configuration#testenvironment-string
Refs: stackoverflow.com/a/68656890
This reverts commit db212a4.
We no longer test in Node.js 10.x
@trivikr trivikr changed the base branch from remove-jest-from-packages to main January 4, 2022 14:44
@trivikr
Copy link
Member Author

trivikr commented Jan 4, 2022

Superceded by #3130

@trivikr trivikr closed this Jan 4, 2022
@trivikr trivikr deleted the jest-27 branch January 4, 2022 14:48
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to Jest 27 for unit testing
2 participants