fix(clients): merge default variants by comparing tags#3044
Merged
fix(clients): merge default variants by comparing tags#3044
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3044 +/- ##
=======================================
Coverage 58.76% 58.76%
=======================================
Files 567 567
Lines 30360 30360
Branches 7482 7482
=======================================
Hits 17841 17841
Misses 12519 12519
Continue to review full report at Codecov.
|
...t-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/EndpointGenerator.java
Show resolved
Hide resolved
AllanZhengYP
approved these changes
Nov 19, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3043
Description
Merges variants from partition defaults and service defaults using tags as unique key
Testing
Verified that endpoint resolution returns
dynamodb.us-gov-east-1.api.awsfor DynamoDB with region=us-gov-east-1 and useDualstackEndpoint=trueCode
Output
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.