chore(clients): populate variants in endpoints hashes#2962
Closed
chore(clients): populate variants in endpoints hashes#2962
Conversation
trivikr
force-pushed
the
populate-variants-endpoint-hashes
branch
from
408d339 to
26abd2a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2962 +/- ##
=======================================
Coverage 58.70% 58.70%
=======================================
Files 566 566
Lines 30315 30315
Branches 7460 7460
=======================================
Hits 17796 17796
Misses 12519 12519
Continue to review full report at Codecov.
|
trivikr
force-pushed
the
populate-variants-endpoint-hashes
branch
from
26abd2a to
d468909
Compare
trivikr
force-pushed
the
populate-variants-endpoint-hashes
branch
2 times, most recently
from
dad6a21 to
807389a
Compare
AllanZhengYP
approved these changes
Nov 1, 2021
trivikr
force-pushed
the
populate-variants-endpoint-hashes
branch
from
807389a to
42e7158
Compare
Member
Author
|
Superceded by #2974 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-2908
Follow-up to #2947
Cleaned up PR of #2957
Note: A new PR will be posted with final endpoints.json, once it's available. Expected date: 11/02.
Description
Populates variants in endpoints hashes.
Testing
N/A as variants are additive. The functional tests are successful.
The follow-up PRs will update unit tests in config-resolver, and affected middleware packages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.