Strict date parsing regeneration#2760
Merged
JordonPhillips merged 2 commits intoaws:mainfrom Sep 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2760 +/- ##
=======================================
Coverage 60.36% 60.36%
=======================================
Files 554 554
Lines 28841 28841
Branches 7060 7060
=======================================
Hits 17411 17411
Misses 11430 11430
Continue to review full report at Codecov.
|
JordonPhillips
approved these changes
Sep 8, 2021
JordonPhillips
suggested changes
Sep 8, 2021
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java
Outdated
Show resolved
Hide resolved
Uses strict parsing methods to deserialize timestamp values. Enables timestamp malformed request tests in the SSDK as well.
Regenerates to use strict timestamp parsing
adamthom-amzn
force-pushed
the
strict-date-parsing-regeneration
branch
from
c3c810f to
b6eaedc
Compare
Contributor
Author
|
Tests are going to fail until smithy-lang/smithy-typescript#416 is merged |
AllanZhengYP
approved these changes
Sep 8, 2021
JordonPhillips
approved these changes
Sep 9, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regenerate clients and protocol tests with strict date parsing enabled.
Testing
Ran the protocol tests locally.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.