fix(client-sts): duplicate stripInternal entry in tsconfig#2545
Merged
AllanZhengYP merged 1 commit intoaws:mainfrom Jul 21, 2021
Merged
fix(client-sts): duplicate stripInternal entry in tsconfig#2545AllanZhengYP merged 1 commit intoaws:mainfrom
AllanZhengYP merged 1 commit intoaws:mainfrom
Conversation
This caused an error for me when bundling with esbuild
> node_modules/@aws-sdk/client-ecs/node_modules/@aws-sdk/client-sts/tsconfig.json:26:4: warning: Duplicate key "stripInternal" in object literal
26 │ "stripInternal": true,
╵ ~~~~~~~~~~~~~~~
aaroncowie
changed the title
Contributor
Author
|
Feel free to reject this pull request and push the change separately, just wanted to flag this as an issue. |
Codecov Report
@@ Coverage Diff @@
## main #2545 +/- ##
=======================================
Coverage ? 60.24%
=======================================
Files ? 513
Lines ? 27359
Branches ? 6577
=======================================
Hits ? 16482
Misses ? 10877
Partials ? 0 Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
approved these changes
Jul 16, 2021
AllanZhengYP
changed the title
AllanZhengYP
approved these changes
Jul 21, 2021
AllanZhengYP
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
No issue
Description
What does this implement/fix? Explain your changes.
This caused a warning for me when bundling with esbuild
Testing
How was this change tested?
Not tested, change made through github web ui
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.