fix: replace prepublishOnly script with downlevel-dts#2537
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2537 +/- ##
=======================================
Coverage ? 59.55%
=======================================
Files ? 495
Lines ? 26411
Branches ? 6272
=======================================
Hits ? 15729
Misses ? 10682
Partials ? 0 Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Jul 1, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2474
Description
The
prepublishOnlyscript was running in our release automation with the following error:Due to this error, the downlevelled types were not getting published.
This happened as we ran
npm publishscript using package directory in our release automation, and npm cli ranprepublishOnlyscript from root directory.The fix is to rename
prepublishOnlytodownlevel-dtsand call it explicitly from our release automation. Theyarn buildis not required asdistfolder is already present.Testing
prepublishOnlyscript with package directory in release automation scripts.prepublishOnlycall withdownlevel-dtsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.