feat(util-waiter): add createWaiter()#1759
Merged
alexforsyth merged 5 commits intoaws:masterfrom Dec 14, 2020
Merged
Conversation
alexforsyth
approved these changes
Dec 10, 2020
Contributor
alexforsyth
left a comment
There was a problem hiding this comment.
@AllanZhengYP and I discussed this offline. LGTM! This is awesome
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
+ Coverage 79.77% 79.85% +0.07%
==========================================
Files 325 338 +13
Lines 12087 12644 +557
Branches 2553 2684 +131
==========================================
+ Hits 9643 10097 +454
- Misses 2444 2547 +103
Continue to review full report at Codecov.
|
mtdowling
suggested changes
Dec 10, 2020
Refactor the original waiter util: 1. expose a createWaiter() only to clients in order to reduce the duplicated code-gen 2. fix infinite loop in job poller 3. fix potential number overflow
979186a to
5ce19d1
Compare
The racing maxWaitTime will set a timeout that would eventually hang the user's process. So remove it. Instead, we break the poller promise if the totol wait time get close to the maxWaitTime config.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors: #1736
Refactor the original waiter util:
Example of how clients may use these utils:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.