Skip to content

DDB Enhanced Client: Support for recursive self-referencing annotated… #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

bmaizels
Copy link
Contributor

@bmaizels bmaizels commented Sep 4, 2020

… record classes

Self-referencing DynamoDB clients were causing stack overflow when initialized as a TableSchema (bean or immutable). This is a fix to make them work correctly.

Description

Implemented a ThreadLocal cache that stores uninitialized reference stubs for TableSchema objects under creation to facilitate self-referencing.

Testing

Added new tests. Ran existing tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@bmaizels bmaizels requested a review from joviegas September 4, 2020 17:40
@bmaizels bmaizels force-pushed the bmaizels/ddbenhanced-recursive-fix branch from d75376f to 08af927 Compare September 4, 2020 18:31
@bmaizels bmaizels force-pushed the bmaizels/ddbenhanced-recursive-fix branch from 08af927 to 627054d Compare September 4, 2020 19:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

97.8% 97.8% Coverage
2.9% 2.9% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@bmaizels bmaizels merged commit db44cce into master Sep 8, 2020
@bmaizels bmaizels deleted the bmaizels/ddbenhanced-recursive-fix branch September 8, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants