Update CF CookieSigner to use crypto.Signer interface#3325
Open
Update CF CookieSigner to use crypto.Signer interface#3325
Conversation
CloudFront CookieSigner uses *rsa.PrivateKey, but CloudFront supports ECDSA since 2025. To support ECDSA, this commit makes CookieSigner accept crypto.Signer, including *rsa.PrivateKey and *ecdsa.PrivateKey. For CF URLSigner, the same change was done by bedf94c.
dw-kihara
force-pushed
the
cf-cookie-signer-interface
branch
from
bd286b0 to
e2daf20
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
CookieSignerto usecrypto.Signerin order to support ECDSA keys and other signing methods.CloudFront supports ECDSA since 2025, but
CookieSigneraccepts only*rsa.PrivateKeyand thus prevents users from using ECDSA in Go. This change makesCookieSigneraccept*ecdsa.PrivateKeyand other signing methods in addition to*rsa.PrivateKey(which also implements crypto.Signer). Existing*rsa.PrivateKeyusage is compatible with this change.For
URLSigner, #2087 has resolved the problem.