Skip to content

Add metrics documentation #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Add metrics documentation #491

merged 2 commits into from
Sep 14, 2021

Conversation

artificial-aidan
Copy link
Contributor

Description of changes:

Add documentation of the available metrics. Took me longer than I care to admit to figure out which metrics were available because they aren't namespaced with aws_node_termintation or similar

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Aidan Jensen <[email protected]>
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, and thank you for your contribution!

Since this is such a short section, we'd prefer to keep it in a file that gets more traffic, like the main README.md (perhaps after the "Building" section). That will make it more likely to stay up-to-date in the future.

Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants