Skip to content

Various PKCS7 fixups#3035

Merged
WillChilds-Klein merged 2 commits intoaws:mainfrom
WillChilds-Klein:pkcs7-fixups
Feb 25, 2026
Merged

Various PKCS7 fixups#3035
WillChilds-Klein merged 2 commits intoaws:mainfrom
WillChilds-Klein:pkcs7-fixups

Conversation

@WillChilds-Klein
Copy link
Copy Markdown
Contributor

@WillChilds-Klein WillChilds-Klein commented Feb 24, 2026

Notes

Some miscellaneous fixups to our PKCS7 implementation:

  • prevent potential BIO leak on write failure
  • fix return value of PKCS7_set_detached
  • prevent SIGABRT crash on allocation failure
  • wipe aliased cipher_bio pointer
  • forbid negative lengths when parsing
  • zeroize stack-allocated MMA key in failure cases (basically a non-issue because it's error path and nothing usable is returned)

Testing

  • CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.51%. Comparing base (0628190) to head (a2b0630).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/pkcs7/pkcs7.c 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
+ Coverage   78.35%   78.51%   +0.16%     
==========================================
  Files         689      689              
  Lines      121010   121017       +7     
  Branches    16992    16997       +5     
==========================================
+ Hits        94813    95019     +206     
+ Misses      25302    25098     -204     
- Partials      895      900       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WillChilds-Klein WillChilds-Klein merged commit c6d7b33 into aws:main Feb 25, 2026
547 of 551 checks passed
@WillChilds-Klein WillChilds-Klein deleted the pkcs7-fixups branch February 25, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants