Conversation
60d5d5b to
58b02b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
==========================================
+ Coverage 78.31% 78.32% +0.01%
==========================================
Files 689 689
Lines 121007 121007
Branches 16996 16972 -24
==========================================
+ Hits 94765 94783 +18
+ Misses 25346 25329 -17
+ Partials 896 895 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
58b02b3 to
350c240
Compare
350c240 to
3e80c60
Compare
3e80c60 to
a208e73
Compare
a208e73 to
3941c41
Compare
1a1a6ff to
e532587
Compare
sgmenda
previously approved these changes
Feb 12, 2026
Contributor
sgmenda
left a comment
There was a problem hiding this comment.
lgtm, but I think we should add a paragraph under "Platform Support" in the repo README.md about security implications.
sgmenda
approved these changes
Feb 19, 2026
Contributor
sgmenda
left a comment
There was a problem hiding this comment.
lgtm, I like the README changes
samuel40791765
approved these changes
Feb 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: P372521248
Description of changes:
This PR adds support for building and testing AWS-LC with WebAssembly (WASM) using an Emscripten toolchain.
Description
OPENSSL_WASMwhen compiling with__wasm__to enable WASM-specific code pathsgetentropy()for random number generation, which Emscripten providesutil/wasm-toolchain.cmaketests/ci/run_emscripten_tests.shfor testing.Call-outs:
fork()or POSIX sockets are excluded as these are not supported in the WASM/Emscripten environmentsTesting:
crypto_test,urandom_test, andssl_testin a WASM/Node.js environmentBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.