Skip to content

Fix link in README.md#2945

Merged
justsmth merged 4 commits intoaws:mainfrom
ofek:patch-1
Feb 25, 2026
Merged

Fix link in README.md#2945
justsmth merged 4 commits intoaws:mainfrom
ofek:patch-1

Conversation

@ofek
Copy link
Copy Markdown
Contributor

@ofek ofek commented Jan 15, 2026

Hello team! I noticed the issue while investigating potential adoption. The porting guide refactor in #1463 missed this.

I also took the liberty of splitting the affected run-on sentence.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@ofek ofek requested a review from a team as a code owner January 15, 2026 17:03
@justsmth justsmth enabled auto-merge (squash) January 15, 2026 17:11
@justsmth
Copy link
Copy Markdown
Contributor

Thanks for the PR!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.35%. Comparing base (0628190) to head (01ee5b8).
⚠️ Report is 65 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2945   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files         689      689           
  Lines      121010   121010           
  Branches    16992    16992           
=======================================
+ Hits        94813    94816    +3     
+ Misses      25302    25298    -4     
- Partials      895      896    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth
Copy link
Copy Markdown
Contributor

justsmth commented Jan 16, 2026

Hi -- we have a required CI job failing due to the license statement not being found in the PR description. If you agree, would you add the following statement to this description:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

I can then rerun this job and get this merged. Thanks!

@ofek
Copy link
Copy Markdown
Contributor Author

ofek commented Jan 16, 2026

Sure thing, I updated the PR description accordingly!

@geedo0
Copy link
Copy Markdown
Contributor

geedo0 commented Jan 20, 2026

/codebuild_run(9c92dfb)

@ofek
Copy link
Copy Markdown
Contributor Author

ofek commented Feb 13, 2026

Should I do anything about the failing jobs?

@justsmth justsmth disabled auto-merge February 25, 2026 13:59
@justsmth justsmth merged commit 129ffc0 into aws:main Feb 25, 2026
442 of 455 checks passed
@ofek
Copy link
Copy Markdown
Contributor Author

ofek commented Feb 25, 2026

Thanks everyone! In future, is there anything one can do as a contributor to ease the review? I see this section of the contributing docs but it's quite basic and doesn't discuss ways to ensure a speedy contribution/merge loop.

@ofek ofek deleted the patch-1 branch February 25, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants