Conversation
|
Thanks for the PR! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 689 689
Lines 121010 121010
Branches 16992 16992
=======================================
+ Hits 94813 94816 +3
+ Misses 25302 25298 -4
- Partials 895 896 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi -- we have a required CI job failing due to the license statement not being found in the PR description. If you agree, would you add the following statement to this description:
I can then rerun this job and get this merged. Thanks! |
|
Sure thing, I updated the PR description accordingly! |
|
/codebuild_run(9c92dfb) |
|
Should I do anything about the failing jobs? |
|
Thanks everyone! In future, is there anything one can do as a contributor to ease the review? I see this section of the contributing docs but it's quite basic and doesn't discuss ways to ensure a speedy contribution/merge loop. |
Hello team! I noticed the issue while investigating potential adoption. The porting guide refactor in #1463 missed this.
I also took the liberty of splitting the affected run-on sentence.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.