Skip to content

Document and statically assert counters can't overflow #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: randomness_generation
Choose a base branch
from

Conversation

torben-hansen
Copy link
Contributor

Description of changes:

2^48 is generally an upper bound on number of CTR-DRBG invocations without reseed. Statically assert type is large enough and for other counters document that 2^64 is the assumed strict upper bound.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@torben-hansen torben-hansen requested a review from a team as a code owner July 8, 2025 19:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (85f783d) to head (ffa0f12).
Report is 1 commits behind head on randomness_generation.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           randomness_generation    #2528      +/-   ##
=========================================================
+ Coverage                  78.86%   78.87%   +0.01%     
=========================================================
  Files                        637      637              
  Lines                     110439   110468      +29     
  Branches                   15622    15622              
=========================================================
+ Hits                       87095    87132      +37     
+ Misses                     22591    22582       -9     
- Partials                     753      754       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@torben-hansen torben-hansen requested review from dkostic and justsmth July 8, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants