Skip to content

Add support for Apple tvOS builds #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

matszczygiel
Copy link

Description of changes:

This PR makes it possible to build aws-lc-rs for Apple tvOS platform. The compilation works out of the box with only some defines missing.

Testing:

I've tested the build for aarch64-apple-tvos platform.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@matszczygiel matszczygiel requested a review from a team as a code owner July 22, 2025 09:22
Signed-off-by: Mateusz Szczygieł <[email protected]>
@justsmth
Copy link
Contributor

Thanks for the PR!

Do you know whether it would be possible to build for Apple tvOS in the GitHub CI? If so, I can add myself a backlog task to set it up.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (c358484) to head (66f8efb).
Report is 234 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   95.80%   92.39%   -3.41%     
==========================================
  Files          61       71      +10     
  Lines        8143     9065     +922     
  Branches        0     9065    +9065     
==========================================
+ Hits         7801     8376     +575     
- Misses        342      423      +81     
- Partials        0      266     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matszczygiel
Copy link
Author

@justsmth I believe it should work as any other Apple cross-compilation job with the following differences:

  • it requires nightly toolchain
  • the build command is slightly different cargo +nightly build -Zbuild-std --target aarch64-apple-tvos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants