Skip to content

Support for sign/verify w/ digest #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jun 17, 2025

Description of changes:

  • Support for signing/verifying precomputed digests.
    • Supported by RSA and ECDSA.
    • ML-DSA and Ed25519 do not allow precomputed digests to be used.
  • Added/updated documentation.

Testing:

  • Update existing tests to also cover precomputed digests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 92.03540% with 18 lines in your changes missing coverage. Please review.

Project coverage is 92.39%. Comparing base (c358484) to head (2819d6e).
Report is 234 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/evp_pkey.rs 88.57% 4 Missing and 4 partials ⚠️
aws-lc-rs/src/rsa/signature.rs 92.30% 1 Missing and 2 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 85.71% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/ec/signature.rs 93.93% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/rsa/key.rs 91.66% 1 Missing and 1 partial ⚠️
aws-lc-rs/src/digest.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   95.80%   92.39%   -3.41%     
==========================================
  Files          61       71      +10     
  Lines        8143     9280    +1137     
  Branches        0     9280    +9280     
==========================================
+ Hits         7801     8574     +773     
- Misses        342      430      +88     
- Partials        0      276     +276     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the sign-digest branch 9 times, most recently from befe4f5 to b130385 Compare July 16, 2025 20:42
@justsmth justsmth changed the title [DRAFT] Init impl for sign/verify w/ digest Support for sign/verify w/ digest Jul 16, 2025
@justsmth justsmth marked this pull request as ready for review July 16, 2025 20:47
@justsmth justsmth requested a review from a team as a code owner July 16, 2025 20:47
skmcgrail
skmcgrail previously approved these changes Jul 19, 2025
@justsmth justsmth merged commit bc79bcb into aws:main Aug 5, 2025
289 checks passed
@justsmth justsmth deleted the sign-digest branch August 5, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants