Skip to content

Conversation

@vanekjar
Copy link
Contributor

@vanekjar vanekjar commented Oct 26, 2021

Closes #41

Fixing controllers permission using kubebuilder markers. Cluster role is generated based on that during build.

https://book.kubebuilder.io/reference/markers/rbac.html

@vanekjar vanekjar requested a review from astaticvoid October 26, 2021 01:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.32%. Comparing base (ba9b31c) to head (a8386ce).
Report is 161 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   42.32%   42.32%           
=======================================
  Files           9        9           
  Lines         997      997           
=======================================
  Hits          422      422           
  Misses        560      560           
  Partials       15       15           
Files with missing lines Coverage Δ
pkg/controllers/cloudmap_controller.go 0.00% <ø> (ø)
pkg/controllers/serviceexport_controller.go 43.93% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9b31c...a8386ce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vanekjar vanekjar merged commit 8f8df95 into aws:main Oct 26, 2021
@vanekjar vanekjar deleted the rbac branch October 26, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RBAC Issue

4 participants