-
Notifications
You must be signed in to change notification settings - Fork 29
Check cluster ID during service export #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 70.86% 70.59% -0.28%
==========================================
Files 17 17
Lines 1713 1724 +11
==========================================
+ Hits 1214 1217 +3
- Misses 417 423 +6
- Partials 82 84 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
astaticvoid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and improvements :)
Check cluster ID during service export
Issue #, if available: #254
Description of changes:
When exporting a service from Cluster A, we call DiscoverInstances on an entire clusterset in order to determine if there are any changes for the service we wish to export. If there are any changes, all endpoints in that service will be wiped by the endpoints being exported by Cluster A for this service. In order to mitigate this, we must check for the current cluster's endpoints only when calling DiscoverInstances to Cloud Map.
To make sure we obtain the correct endpoints, we will need to invalidate the cache.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.