Skip to content

Clarify SSO to only suggest a different device when using --use-device-code #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Aug 4, 2025

Issue #, if available: P250288278

Description of changes: From the internal ticket, when we added the auth code + PKCE flow, I reused the opening_msg which includes "...you wish to use a different device...".

This is misleading for auth code flow, since you must use the same device to handle the callback.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ashovlin ashovlin changed the title Clarify SSO to only suggest a different device when using `--use-device-code Clarify SSO to only suggest a different device when using --use-device-code Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants