Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Dec 19, 2025

Issue # (if applicable)

N/A

Reason for this change

MSK with Kafka v3.9 now supports express brokers.

Ref: Amazon MSK introduces KRaft support for Express Brokers with Apache Kafka v3.9

Description of changes

Modify a validation and a unit test.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Run unit tests and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 19, 2025 01:12
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 19, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 19, 2025

Exemption Request: only fixed validation logic so I think the integ test is not needed.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Dec 19, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2025
Co-authored-by: gasolima <[email protected]>
@mazyu36 mazyu36 requested a review from gasolima December 19, 2025 12:28
Removed outdated comment about Kafka version compatibility documentation.
@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 20, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2025

update

✅ Branch has been successfully updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants