Skip to content

Conversation

@notSoWiseOldMan
Copy link

@notSoWiseOldMan notSoWiseOldMan commented Dec 4, 2025

Reason for this change

controlPlaneScalingConfig was an option added to EKS clusters recently. This was added to CFN and the level 1 structure. This PR adds it to the level 2 construct.

Description of changes

  • Added controlPlaneScalingConfig to Cluster.
  • Added section to the README
  • Added unit tests for basic controlPlaneScalingConfig validation

Describe any new or updated permissions being added

None

Description of how you validated changes

Tested with unit tests. CFN side changes have been tested separately and this change is not doing anything more than just passing through the level 1 cfnCluster properties.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 4, 2025 23:08
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 4, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@notSoWiseOldMan notSoWiseOldMan force-pushed the eks/controlPlaneScalingConfig branch 2 times, most recently from a7a063d to e060d94 Compare December 8, 2025 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results75 ran73 passed2 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
iam-no-overly-permissive-passrole.guard❌ failure
iam-no-world-accessible-trust-policy.guard❌ failure

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates75 ran75 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 11, 2025 19:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 12, 2025 18:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@notSoWiseOldMan notSoWiseOldMan force-pushed the eks/controlPlaneScalingConfig branch 4 times, most recently from 1260d99 to c47d37c Compare December 18, 2025 22:55
@notSoWiseOldMan notSoWiseOldMan force-pushed the eks/controlPlaneScalingConfig branch from c47d37c to 299bd79 Compare December 19, 2025 18:10
@notSoWiseOldMan
Copy link
Author

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined. Please try merge from main to avoid findings unrelated to the PR.
Tests Passed ✅ Skipped Failed
Security Guardian Results with resolved templates 75 ran 75 passed
Test Result
No test annotations available

* [View Security Guardian Results with resolved templates](https://github.com/aws/aws-cdk/runs/58485001756)

This report shows all passing tests but the one just above it shows some failing. Both are marked as experimental and security guardian is passing locally in my devcontainer. Do we need all experimental security guardian pipelines to pass?

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants