-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: adding controlPlaneScalingConfig to Cluster #36302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: adding controlPlaneScalingConfig to Cluster #36302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
a7a063d to
e060d94
Compare
|
|
||||||||||||||||||||
|
|
||||||||||||||
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
1260d99 to
c47d37c
Compare
c47d37c to
299bd79
Compare
This report shows all passing tests but the one just above it shows some failing. Both are marked as experimental and security guardian is passing locally in my devcontainer. Do we need all experimental security guardian pipelines to pass? |
Reason for this change
controlPlaneScalingConfigwas an option added to EKS clusters recently. This was added to CFN and the level 1 structure. This PR adds it to the level 2 construct.Description of changes
Describe any new or updated permissions being added
None
Description of how you validated changes
Tested with unit tests. CFN side changes have been tested separately and this change is not doing anything more than just passing through the level 1 cfnCluster properties.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license