Skip to content

feat(logs): support ADC regions for infrequent access log class #34999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2025
Merged

feat(logs): support ADC regions for infrequent access log class #34999

merged 6 commits into from
Jul 18, 2025

Conversation

natsen1004
Copy link
Contributor

Issue # (if applicable)

ADC regions are hardcoded as unsupported regions for Infrequent Access Log Class

Reason for this change

In the Zero-Touch Region Build (ZTRB) compliance effort for Infrequent Access Log Class, ADC regions are a part of the supported regions.

Description of changes

Removing logGroupClassUnsupportedRegions which include ADC regions

Description of how you validated changes

tested locally

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 16, 2025 16:19
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 17, 2025
@aemada-aws aemada-aws self-assigned this Jul 18, 2025
aemada-aws
aemada-aws previously approved these changes Jul 18, 2025
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aemada-aws
Copy link
Contributor

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot dismissed aemada-aws’s stale review July 18, 2025 20:43

Pull request has been modified.

@aemada-aws aemada-aws changed the title chore(cloudwatchlogs): remove adc regions from unsupported regions for ia log class fix(cloudwatchlogs): remove adc regions from unsupported regions for ia log class Jul 18, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aemada-aws aemada-aws added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 18, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 18, 2025 20:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aemada-aws aemada-aws changed the title fix(cloudwatchlogs): remove adc regions from unsupported regions for ia log class feat(cloudwatchlogs): support adc regions for infrequent access log class Jul 18, 2025
@aemada-aws aemada-aws added the pr/do-not-merge This PR should not be merged at this time. label Jul 18, 2025
@aemada-aws aemada-aws changed the title feat(cloudwatchlogs): support adc regions for infrequent access log class feat(aws-logs): support adc regions for infrequent access log class Jul 18, 2025
@aemada-aws aemada-aws removed the pr/do-not-merge This PR should not be merged at this time. label Jul 18, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aemada-aws aemada-aws changed the title feat(aws-logs): support adc regions for infrequent access log class feat(aws-logs): support ADC regions for infrequent access log class Jul 18, 2025
@aemada-aws aemada-aws changed the title feat(aws-logs): support ADC regions for infrequent access log class feat(logs): support ADC regions for infrequent access log class Jul 18, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 18, 2025 21:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 58ad419
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1c57d69 into aws:main Jul 18, 2025
62 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aemada-aws aemada-aws aemada-aws approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees

@aemada-aws aemada-aws

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natsen1004 @aemada-aws @aws-cdk-automation