Skip to content

chore(route53): support new partition in route53 cross-account delegator #34852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(route53): support new partition in route53 cross-account delegator #34852

wants to merge 1 commit into from

Conversation

moriano
Copy link

@moriano moriano commented Jun 29, 2025 •
edited
Loading

Issue


### Reason for this change

This adds support for the eusc-de partition, without this we cannot perform DNS delegation in any regions in such partition. 

See https://github.com/aws/aws-cdk/commit/3a78125abc5a409a3124d44a33ecbcd4c1a4d269 for similar issues

### Description of changes
Simply added the new eusc-de partition to a list of already hardcoded partitions

### Describe any new or updated permissions being added

N/A


### Description of how you validated changes



### Checklist


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@aws-cdk-automation aws-cdk-automation requested a review from a team June 29, 2025 22:36
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 29, 2025
aws-cdk-automation
aws-cdk-automation requested changes Jun 29, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

fix(route53): Added support for eusc-de partition
7903cd7 
eusc-de regions cannot make use of the cross-account delegator.

We get an error

```
Received response status [FAILED] from custom resource. Message returned: InvalidClientTokenId: The security token included in the request is invalid
```

This has ocurred in the past when new partitions came in too. See aws@3a78125

This is a minor update to a mapping that has no existing unit tests. I'm happy to add if desired, but likely unnecessary.

- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@moriano moriano force-pushed the fix/route53-cross-account-delegation branch from 601678e to 7903cd7 Compare June 29, 2025 23:03
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7903cd7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Open
@kumvprat kumvprat changed the title fix(route53): Added support for eusc-de partition chore(route53): support new partition in route53 cross-account delegator Jul 1, 2025
@leonmk-aws
Copy link
Contributor

The build in this PR was failing because the snapshots weren't updated, I created a new PR for this change as I don't have permissions to update this PR: #34879, I'll close this PR since the other has been merged.

In parallel the team is working on making all the other required changes in this PR: #34860 (WiP)

@leonmk-aws leonmk-aws closed this Jul 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2025
@leonmk-aws leonmk-aws self-assigned this Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

@leonmk-aws leonmk-aws

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moriano @aws-cdk-automation @leonmk-aws