fix(autoscaling): add an option to run validation when migrating to launch template #34832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
aws-cdk-automation
previously requested changes
Jun 27, 2025
jungseoklee
force-pushed
the
for-autoscaling-lt-update-policy
branch
from
eaacbd7 to
a5ec18f
Compare
jungseoklee
changed the title
jungseoklee
force-pushed
the
for-autoscaling-lt-update-policy
branch
from
a5ec18f to
4ae6e8e
Compare
jungseoklee
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
Any updates, please? |
alvazjor
previously requested changes
Jul 16, 2025
aws-cdk-automation
removed
the
pr/needs-community-review
jungseoklee
force-pushed
the
for-autoscaling-lt-update-policy
branch
from
4ae6e8e to
e2dac2e
Compare
jungseoklee
force-pushed
the
for-autoscaling-lt-update-policy
branch
from
e2dac2e to
a434376
Compare
…aunch template This patch add an option to run validation when migrating to launch template, which checks if AutoScalingRollingUpdate is used.
jungseoklee
force-pushed
the
for-autoscaling-lt-update-policy
branch
from
a434376 to
8f5a184
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add an option to run validation when migrating to launch template, which checks if UpdatePolicy is specified.
Issue # (if applicable)
Closes #34283.
Reason for this change
To make migration to Launch Template safer.
Description of changes
This change introduces an option flag to check whether or not UpdatePolicy is specified. As enforcing UpdatePolicy, existing EC2 instances based on Launch Configuration are terminated, and new EC2 instances based on Launch Template are launched, which always references IAM instance profile defined by Launch Template.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added an unit test and integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license