-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(synthetics): add support for tag replication for aws synthetics #34830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): add support for tag replication for aws synthetics #34830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've added a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@lvthillo Could you please merge the latest main branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this change! I've suggested a couple of test additions which will help us to ensure that everything works as expected.
...testing/framework-integ/test/aws-synthetics/test/integ.canary-resources-to-replicate-tags.ts
Show resolved
Hide resolved
Pull request has been modified.
Pull request has been modified.
@vishaalmehrishi I saw the build fail, so I thought I'd merge in main again, but that turned out to be a bad idea because your approval is dismissed now |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34948. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
This pull request has been removed from the queue for the following reason: Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34950. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
This pull request has been removed from the queue for the following reason: Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34959. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
This pull request has been removed from the queue for the following reason: Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34966. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
…st functionality can not handle it for this specific case
ac8d4c2
to
17fb3a0
Compare
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34811
Related: aws-cloudformation/cloudformation-coverage-roadmap#1101
Reason for this change
Support for tag propagation to underlying resources (Lambda) for AWS Synthetics.
Description of changes
Add support for
ResourcesToReplicateTags
property (like CF)Describe any new or updated permissions being added
/
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license