Skip to content

Conversation

lvthillo
Copy link
Contributor

@lvthillo lvthillo commented Jun 26, 2025

Issue # (if applicable)

Closes #34811

Related: aws-cloudformation/cloudformation-coverage-roadmap#1101

Reason for this change

Support for tag propagation to underlying resources (Lambda) for AWS Synthetics.

Description of changes

Add support for ResourcesToReplicateTags property (like CF)

Describe any new or updated permissions being added

/

Description of how you validated changes

  • Added unit test
  • Added integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jun 26, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 26, 2025 17:50
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@lvthillo lvthillo changed the title feat(aws-synthetics): add support for tag replication for aws synthetics feat(synthetics): add support for tag replication for aws synthetics Jun 26, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 26, 2025 17:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2025
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've added a minor comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 28, 2025
@lvthillo lvthillo requested a review from badmintoncryer June 28, 2025 21:30
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@badmintoncryer
Copy link
Contributor

@lvthillo Could you please merge the latest main branch? needs-maintainer-review label would be attached.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 30, 2025
@vishaalmehrishi vishaalmehrishi self-assigned this Jul 8, 2025
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change! I've suggested a couple of test additions which will help us to ensure that everything works as expected.

@vishaalmehrishi vishaalmehrishi removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 8, 2025
@mergify mergify bot dismissed vishaalmehrishi’s stale review July 8, 2025 20:01

Pull request has been modified.

vishaalmehrishi
vishaalmehrishi previously approved these changes Jul 9, 2025
@mergify mergify bot dismissed vishaalmehrishi’s stale review July 9, 2025 19:53

Pull request has been modified.

@lvthillo
Copy link
Contributor Author

lvthillo commented Jul 9, 2025

@vishaalmehrishi I saw the build fail, so I thought I'd merge in main again, but that turned out to be a bad idea because your approval is dismissed now

Copy link
Contributor

mergify bot commented Jul 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Jul 10, 2025
Copy link
Contributor

mergify bot commented Jul 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34948.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jul 10, 2025
Copy link
Contributor

mergify bot commented Jul 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34950.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@vishaalmehrishi
Copy link
Contributor

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Jul 10, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Jul 10, 2025
Copy link
Contributor

mergify bot commented Jul 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34959.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@vishaalmehrishi
Copy link
Contributor

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Jul 11, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Jul 11, 2025
Copy link
Contributor

mergify bot commented Jul 11, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34830 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34966.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@vishaalmehrishi vishaalmehrishi force-pushed the feat-aws-synthetics-resources-to-replicate-tags branch from ac8d4c2 to 17fb3a0 Compare July 11, 2025 09:57
@mergify mergify bot dismissed vishaalmehrishi’s stale review July 11, 2025 09:58

Pull request has been modified.

Copy link
Contributor

mergify bot commented Jul 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b13778f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jul 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5ff59d9 into aws:main Jul 11, 2025
10 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2025
@lvthillo lvthillo deleted the feat-aws-synthetics-resources-to-replicate-tags branch July 13, 2025 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-synthetics): (Support ResourcesToReplicateTags)
4 participants