Skip to content

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #34692

Reason for this change

Description of changes

  • Modify integ.elastic-beanstalk-hostedzoneid to use standalone @aws-cdk/region-info. We still have integ.elastic-beanstalk-environment-target using monolithic one
  • Remove duplicate exports
    "./core/lib/errors": "./core/lib/errors.js",
    "./core/lib/helpers-internal": "./core/lib/helpers-internal/index.js",
    "./core/lib/metadata-resource": "./core/lib/metadata-resource.js",
    "./core/lib/prop-injectable": "./core/lib/prop-injectable.js",
    "./core/lib/errors": "./core/lib/errors.js",

Describe any new or updated permissions being added

Description of how you validated changes

Reproducing:

  1. Change integ to use standalone @aws-cdk/region-info
  2. Build integ
  3. Remove export in packages/aws-cdk-lib/package.json
  4. Build aws-cdk-lib
  5. Run integ > error
$ yarn integ test/aws-route53-targets/test/integ.elastic-beanstalk-hostedzoneid.js
yarn run v1.22.22
$ integ-runner --language javascript test/aws-route53-targets/test/integ.elastic-beanstalk-hostedzoneid.js

Verifying integration test snapshots...

node:internal/modules/cjs/loader:641
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './core/lib/errors' is not defined by "exports" in /workspaces/aws-cdk/node_modules/aws-cdk-lib/package.json
    at exportsNotFound (node:internal/modules/esm/resolve:322:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:670:9)
    at resolveExports (node:internal/modules/cjs/loader:634:36)
    at Module._findPath (node:internal/modules/cjs/loader:724:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1211:27)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/workspaces/aws-cdk/packages/@aws-cdk/region-info/lib/fact.js:8:18)
    at Module._compile (node:internal/modules/cjs/loader:1469:14) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Node.js v20.18.3

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2025 00:29
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Jun 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@phuhung273
Copy link
Contributor Author

Exemption Request: no need snapshot change

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 21, 2025
@ozelalisen ozelalisen self-assigned this Jun 26, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 4, 2025
@ozelalisen ozelalisen added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 8, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 8, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 8, 2025 16:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jul 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7961c1d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jul 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6d1bcb3 into aws:main Jul 8, 2025
18 checks passed
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2025
@phuhung273 phuhung273 deleted the integ-region-info branch July 8, 2025 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(region-info): integ test to ensure region info works as expected
3 participants