Skip to content

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #34521

Reason for this change

I think it makes sense as we already have secretsmanager:PutSecretValue, secretsmanager:UpdateSecret

Description of changes

grantWrite add secretsmanager:UpdateSecretVersionStage

Describe any new or updated permissions being added

grantWrite add secretsmanager:UpdateSecretVersionStage

Description of how you validated changes

Unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2025 05:52
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jun 15, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 15, 2025
@ozelalisen ozelalisen self-assigned this Jul 8, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

mergify bot commented Jul 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 04f31b1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jul 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 65d8424 into aws:main Jul 9, 2025
18 checks passed
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2025
@phuhung273 phuhung273 deleted the secretmanager-grantwrite-perm branch July 9, 2025 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-secretsmanager): add UpdateSecretVersionStage to the policy generated by Secret::grantWrite
3 participants