-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(eks-v2-alpha): support eks with k8s 1.33 #34713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why did this PR not make the latest release? We are now pushing a month after the AWS release and unable to deploy and I'd rather not rewrite my deploy to use the old EKS module. |
@darylgraham you can help speed up the process by dropping a like on the issue #34520, CDK team track issue based on react |
43a6883
to
81b6040
Compare
ad080a6
to
1c34f4a
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @pahud, sorry to ping you directly. I just want to know your thought, the team can review later. Im aware that this change contains more than just a new version, making it more difficult for reviewer. Even I dont want to do so. But still did it since:
But if the team think we should keep it small, I'm happy to exclude AL2023 change. Please advise me on how we should proceed. |
@phuhung273 Thank you for reaching out. Yes I am onboard to have minimal required change to include 1.33 support. I will reach out to the maintainer today for their inputs here. |
Thanks so much @pahud for your help 🍻 |
Hi @phuhung273 , thank you for your contribution! Let's keep the PR focused on a single change, and then create a separate PR for the unrelated changes. Generally we put multiple changes in a single PR only if there is some dependency which prevents breaking them up into multiple PRs. |
Thank you @vishaalmehrishi @pahud for your advice, appreciate. I've updated to only add new version and as many integration tests as possible. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34520
Closes #34911
Reason for this change
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Unit + Integ
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license