Skip to content

Conversation

phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Jun 13, 2025

Issue # (if applicable)

Closes #34520
Closes #34911

Reason for this change

Description of changes

  • Support version 1.33
  • Add support for AL2023 EKS optimized AMI + user data since 1.33 no longer support AL2. I believe this change should also be included in v1 module. Please let me know if you guys agree, happy to open another PR adding this to v1
  • Fix failing integration tests
  • Upgrade dependencies: cdk8s-plus-32

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jun 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 13, 2025 11:20
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 13, 2025
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Jun 16, 2025
@darylgraham
Copy link

Why did this PR not make the latest release? We are now pushing a month after the AWS release and unable to deploy and I'd rather not rewrite my deploy to use the old EKS module.

@phuhung273
Copy link
Contributor Author

@darylgraham you can help speed up the process by dropping a like on the issue #34520, CDK team track issue based on react

@github-actions github-actions bot added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Jul 10, 2025
@phuhung273 phuhung273 force-pushed the eks-v2-133 branch 2 times, most recently from 43a6883 to 81b6040 Compare July 30, 2025 10:37
@phuhung273 phuhung273 force-pushed the eks-v2-133 branch 2 times, most recently from ad080a6 to 1c34f4a Compare August 6, 2025 05:25
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1c34f4a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@phuhung273
Copy link
Contributor Author

Hi @pahud, sorry to ping you directly. I just want to know your thought, the team can review later.

Im aware that this change contains more than just a new version, making it more difficult for reviewer. Even I dont want to do so. But still did it since:

  • Managed NodeGroup >= 1.33 no longer support AL2, making some integration tests fail
  • I followed your instruction carefully feat(eks-v2-alpha): support eks with k8s 1.32 #33344 (comment) to ensure all integration passed for v2 alpha package (v1 only minimal change). IMO, this is a good way so we can can ensure better coverage for v2 alpha.

But if the team think we should keep it small, I'm happy to exclude AL2023 change. Please advise me on how we should proceed.

@pahud
Copy link
Contributor

pahud commented Aug 19, 2025

@phuhung273 Thank you for reaching out. Yes I am onboard to have minimal required change to include 1.33 support. I will reach out to the maintainer today for their inputs here.

@phuhung273
Copy link
Contributor Author

Thanks so much @pahud for your help 🍻

@vishaalmehrishi
Copy link
Contributor

Hi @phuhung273 , thank you for your contribution! Let's keep the PR focused on a single change, and then create a separate PR for the unrelated changes. Generally we put multiple changes in a single PR only if there is some dependency which prevents breaking them up into multiple PRs.

@phuhung273
Copy link
Contributor Author

phuhung273 commented Aug 20, 2025

Thank you @vishaalmehrishi @pahud for your advice, appreciate. I've updated to only add new version and as many integration tests as possible.

Copy link
Contributor

mergify bot commented Aug 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@vishaalmehrishi vishaalmehrishi self-assigned this Aug 21, 2025
Copy link
Contributor

mergify bot commented Aug 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c24565e into aws:main Aug 21, 2025
17 of 18 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2025
@phuhung273 phuhung273 deleted the eks-v2-133 branch August 21, 2025 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-eks-v2-alpha: support for KubernetesVersion.V1_33 (eks): EKS v1.33 support
5 participants