Skip to content

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Jun 11, 2025

See CHANGELOG

…34691)

### Issue #34690 

Closes #34690 

### Reason for this change
PR #33384 released in version `2.200.1` of `@aws-cdk/region-info` imported `UnscopedValidationError` from `aws-cdk-lib/core/lib/errors`, but did not export `errors.js` properly from `aws-cdk-lib`. This resulted in the following error message when attempting to `import { Fact } from '@aws-cdk/region-info'` (`fact.ts` imports `UnscopedValidationError`).

```
❯ node test.js
node:internal/modules/cjs/loader:1228
  throw err;
  ^

Error: Cannot find module 'aws-cdk-lib/core/lib/errors'
Require stack:
- /Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js
- /Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/index.js
- /Volumes/workplace/test-region-info-app/test.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js:8:18)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js',
    '/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/index.js',
    '/Volumes/workplace/test-region-info-app/test.js'
  ]
}

Node.js v20.17.0
```

### Description of changes


Exported `errors.js` from `packages/aws-cdk-lib/package.json`, which makes it available to `@aws-cdk/region-info`.

### Describe any new or updated permissions being added
None.



### Description of how you validated changes



Tested by hand after making this code change, using example code from the linked issue.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iankhou iankhou added pr/no-squash This PR should be merged instead of squash-merging it pr-linter/analytics-metadata-change labels Jun 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 11, 2025 22:29
@github-actions github-actions bot added the p2 label Jun 11, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 11, 2025
@iankhou iankhou self-assigned this Jun 11, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d146442
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4de88bf into v2-release Jun 11, 2025
14 checks passed
@mergify mergify bot deleted the patch/v2.200.2 branch June 11, 2025 23:47
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it pr-linter/analytics-metadata-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants