chore: require cli integ test when changing/adding a feature flag. #34584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
commented
May 29, 2025
Comment on lines
-27
to
-37
| - packages/aws-cdk/bin/** | ||
| - packages/aws-cdk/lib/** | ||
| - packages/aws-cdk/test/** | ||
| - packages/@aws-cdk/cloudformation-diff/lib/** | ||
| - packages/@aws-cdk/cloudformation-diff/test/** | ||
| - packages/@aws-cdk-testing/cli-integ/bin/** | ||
| - packages/@aws-cdk-testing/cli-integ/entrypoints/** | ||
| - packages/@aws-cdk-testing/cli-integ/lib/** | ||
| - packages/@aws-cdk-testing/cli-integ/resources/** | ||
| - packages/@aws-cdk-testing/cli-integ/test/** | ||
| - packages/@aws-cdk-testing/cli-integ/tests/** |
There was a problem hiding this comment.
All of these are irrelevant now that the CLI has moved to a separate repo.
kaizencc
approved these changes
May 29, 2025
mrgrain
approved these changes
May 29, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A feature flag has the potential to impact the behavior of all CDK apps, including those defined as part our CLI integration test package.
For example: #34556
This PR made it so deploying CDK apps with a lambda function now also requires permissions to create log groups. This is not a breaking change for the CDK, but it did broke in our pipeline because of some permission limitations we impose on it.
It could have been caught in the test pipeline.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license