-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore(ec2): update PrefixList.fromLookup()
to expect the result from CcApi context provider has exactly one resource
#34565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…m CcApi context provider has exactly one resource
FYI, just waiting for a new CLI release on this. Than it should be fine. Thanks for re-opening! |
@mrgrain Thanks for the info |
rosetta still fails 😞
|
pushed a fix |
Going trough full pipeline |
packages/aws-cdk-lib/rosetta/cloud_assembly_schema/default.ts-fixture
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/rosetta/cloud_assembly_schema/default.ts-fixture
Outdated
Show resolved
Hide resolved
@Tietew fixing this upstream. Will need another CLI release. |
Nice! I'll have to run this through the full pipeline first. Will take a couple of hours. |
Full pipeline run: |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Re-creation of #34199
A jsii related issue #34199 (comment) should be fixed before merging this PR.
Issue # (if applicable)
Follow-up to #33619.
Reason for this change
CcApi context provider now can expect the matched count of resources: aws/aws-cdk-cli#251.
PrefixList.fromLookup()
is needed to be updated using this feature not to persist invalid results incdk.context.json
.See also aws/aws-cdk-cli#257.
Description of changes
@aws-cdk/cloud-assembly-schema
to latest ^44.1.0.expectedMatchCount: 'exactly-one'
to expect exactly one prefix list id is returned.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Updated integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license