Skip to content

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented May 28, 2025

Re-creation of #34199
A jsii related issue #34199 (comment) should be fixed before merging this PR.

Issue # (if applicable)

Follow-up to #33619.

Reason for this change

CcApi context provider now can expect the matched count of resources: aws/aws-cdk-cli#251.
PrefixList.fromLookup() is needed to be updated using this feature not to persist invalid results in cdk.context.json.
See also aws/aws-cdk-cli#257.

Description of changes

  • Bumped @aws-cdk/cloud-assembly-schema to latest ^44.1.0.
  • Specify expectedMatchCount: 'exactly-one' to expect exactly one prefix list id is returned.
  • Updated validation to check unexpected result. Actual error will be returned from the context provider.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Updated integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…m CcApi context provider has exactly one resource
@github-actions github-actions bot added the p2 label May 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 28, 2025 02:51
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label May 28, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 28, 2025
@mrgrain
Copy link
Contributor

mrgrain commented May 28, 2025

FYI, just waiting for a new CLI release on this. Than it should be fine. Thanks for re-opening!

@Tietew
Copy link
Contributor Author

Tietew commented May 29, 2025

@mrgrain Thanks for the info
aws/aws-cdk-cli#538 will fix it and CLI 2.1017.0 released.
Looks like cloud-assembly-schema needs to be bumped to v44.

@Tietew
Copy link
Contributor Author

Tietew commented May 29, 2025

rosetta still fails 😞

[jsii-rosetta] [INFO] Loading 35 assemblies
[jsii-rosetta] [INFO] Reused 321 translations from cache
[jsii-rosetta] [INFO] Translating
[jsii-rosetta] [INFO] Preparing dependency closure at /tmp/rosettaUTEeqp (-vv for more details)
[jsii-rosetta] [INFO] Translating 2770 snippets using 16 workers
[jsii-rosetta] [INFO] Translated 2770 snippets in 549.508 seconds (0.198s/snippet)
[jsii-rosetta] [INFO] Adding translations to /root/.s3buildcache/rosetta-cache.tabl.json
aws-cdk-lib.cloud_assembly_schema.CcApiContextQuery-example.ts:95:10 - error TS2304: Cannot find name 'CcApiContextQuery'.

95 const x: CcApiContextQuery = {
            ~~~~~~~~~~~~~~~~~
[jsii-rosetta] [WARN] 1 diagnostics from assemblies with 'strict' mode on (and 65 more non-strict diagnostics)

real	9m57.120s
user	122m37.053s
sys	8m41.082s

[Container] 2025/05/29 03:55:22.899333 Command did not exit successfully /bin/bash ./scripts/run-rosetta.sh exit status 1

@mrgrain
Copy link
Contributor

mrgrain commented May 29, 2025

rosetta still fails 😞

pushed a fix

@mrgrain
Copy link
Contributor

mrgrain commented May 29, 2025

Going trough full pipeline 65a120c0

@mrgrain
Copy link
Contributor

mrgrain commented May 29, 2025

@Tietew fixing this upstream. Will need another CLI release.

PR: aws/aws-cdk-cli#554

@mrgrain
Copy link
Contributor

mrgrain commented May 30, 2025

@mrgrain
Copy link
Contributor

mrgrain commented May 30, 2025

Nice! I'll have to run this through the full pipeline first. Will take a couple of hours.

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label May 30, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 30, 2025
@mrgrain
Copy link
Contributor

mrgrain commented May 30, 2025

Full pipeline run: 9914a186

@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label May 30, 2025
Copy link
Contributor

mergify bot commented May 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e65b718
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented May 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 802f130 into aws:main May 30, 2025
16 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2025
@Tietew Tietew deleted the ec2-prefixlist-fromlookup branch June 2, 2025 03:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants