feat(synthetics): add maxRetries prop to configure automatic retries on canary runs

[georeeve]

Issue # (if applicable)

Closes #34511.

Reason for this change

Adds support for configuring automatic retries of Canary runs.

Description of changes

This adds a maxRetries property on the top-level of the CanaryProps interface. It uses this to configure the retryConfig structure on the schedule structure. This works similarly to how the timeToLive property configures the durationInSeconds field on the schedule structure.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

I have updated the unit and integ tests, and have deployed manually, and verified the changes in the AWS console.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

(This review is outdated)

[georeeve]

Clarification Request

I've updated the integ test, but I'm running into an error when trying to run it. I'm getting the following error:
ZipAsset (ZipAssetA028C65F) Resource handler returned message: "Could not unzip uploaded file. Please check your file, then try to upload again. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID:; Proxy: null)" (RequestToken:, HandlerErrorCode: GeneralServiceException)

I'm running yarn integ-runner --directory test/aws-synthetics/test/ --update-on-failed --parallel-regions eu-west-1 from the packages/@aws-cdk-testing/framework-integ directory. Am I perhaps running it from the wrong directory so it can't find the zip file? Or is the zip file failing for some other reason? I'd appreciate any advice on this!

[georeeve]

Looks like the same integ errors were encountered in #34254 which @badmintoncryer managed to resolve. I can try and regenerate the snapshots but it does seem a bit flaky.

[georeeve]

I seem to have gotten around the zip issue, but I'm now getting Synthetics runtime version syn-nodejs-puppeteer-7.0 does not support Auto Retry which makes sense as only v10+ supports auto retries. Unfortunately I think that means we're blocked until #34241 is merged in unless we want to use an escape hatch to override the runtime in the integ test for now (I suspect not)?

[badmintoncryer]

Thank you for your contribution! After your modification, I'll execute integ test later.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 7249498
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.