chore: split codecov to collect and upload workflows #34451
Conversation
| name: coverage-artifacts | ||
| path: | | ||
| packages/aws-cdk-lib/coverage/cobertura-coverage.xml | ||
| pr/NR |
There was a problem hiding this comment.
nit: For my understanding what is the use of sending the PR number? In the another workflow i couldn't see any reference to the PR number being used.
There was a problem hiding this comment.
in case we wanted to use it. let me remove.
| name: Codecov Collect | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Q: should we need this workflow to be triggered for all branch? or can we trigger only for the main branch?
There was a problem hiding this comment.
all branches no. At least I follow a branch per feature on my fork strategy.
There was a problem hiding this comment.
Would like to understand the reason behind separating as two different worklows for codecov instead of a single workflow?
There was a problem hiding this comment.
Separately pinging you.
| - name: Upload Coverage and PR Info | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage-artifacts |
There was a problem hiding this comment.
Should we consider naming the artificat based on PR number or commit id instead of a static name?
There was a problem hiding this comment.
i believe its just gonna be interim in the env of the PR itself. lmk
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
same as
#34247
#34211
Closes #.
Reason for this change
Description of changes
Describe any new or updated permissions being added
Codecov is split into
collectwith lesser permissions anduploadwith escalated permissions.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license