feat: property injectors and make all L2 Constructors injectable #34419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issue # (if applicable) This Implements the Property Injectors RFC. https://github.com/aws/aws-cdk-rfcs/blob/main/text/0693-property-injection.md ### Reason for this change Implement the Property Injectors feature so orgs can set up default Construct props values. ### Description of changes Key changes: * propertyInjectionDecorator to make a Construct Property Injectable. * applyInjectors is called from Construct's constructor to inject property defaults. * IPropertyInjector defines an Property Injector. * PropertyInjectors class that stores the map of Constructs to Injectors. * App, Stage, and Stack now has a new propertyInjectors property. ### Describe any new or updated permissions being added None ### Description of how you validated changes * Unit test in core/test/prop-injectors.test.ts * Use `yarn package --target js` to create a library and write Injectors for Constructs. ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#34328) ### Issue # (if applicable) This is a followup to aws#33887. DO NOT merge this PR until after 33887 is merged. ### Reason for this change In the original Property Injection PR, we enabled 122 Constructs for Property Injections, but we want to make this feature available for all L2 Constructs. ### Description of changes Add logic to Constructs ConstructsUpdater to if a Construct already have PROPERTY_INJECTION_ID property. If not, it will: - Add PROPERTY_INJECTION_ID with value that is calculated from path and class name - Import aws-cdk-lib/core/lib/prop-injectable - Add class decorator @propertyInjectable ### Describe any new or updated permissions being added No permission change. ### Description of how you validated changes - Added unit tests and ran `npm test` - Ran `./bin/update-construct-metadata` locally and manually verified a few random files. ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
github-actions
bot
added
repeat-contributor
aws-cdk-automation
previously requested changes
May 11, 2025
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
pcheungamz
changed the title
aws-cdk-automation
removed
the
pr/needs-community-review
moelasmar
approved these changes
May 13, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
This implements this RFC: https://github.com/aws/aws-cdk-rfcs/blob/main/text/0693-property-injection.md
Description of changes
This PR contains these changes:
Describe any new or updated permissions being added
No new IAM permission.
Description of how you validated changes
Added unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license