Skip to content

feat(cdk-pipeline): add url and sns topic for manual approval in cdk pipeline #34227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pitayapj
Copy link
Contributor

Issue #32809

Relate feature request #12273

Reason for this change

No concrete solution to output cdk diff in pipeline yet.
Include ExternalEntityLink and SNS Topic to manual approval step for custom diff check solution.

Description of changes

Add url for review and SNS topic in ManualApprovalStepProps

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 23, 2025 04:49
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Apr 23, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@pitayapj pitayapj changed the title add url and sns topic for manual approval in cdk pipeline feat(cdk-pipeline): add url and sns topic for manual approval in cdk pipeline Apr 23, 2025
@pitayapj
Copy link
Contributor Author

Exemption Request

Not sure if README and test is needed since this just add supported parameters of codepipeline actions's manual approval action

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 23, 2025
@paulhcsun
Copy link
Contributor

Hi @pitayapj, for all new features we require README updates as well as at least unit tests. Since new properties are being added I think that integration tests to ensure that the deployment is successful is appropriate here too. For the README please include a code example that uses the new properties and describe what they do or add the properties to an existing code example with an additional short description.

@paulhcsun paulhcsun removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label May 12, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 12, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a2561c4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pitayapj
Copy link
Contributor Author

@paulhcsun
understood.
I added test and README, appreciate review when possible. Thanks

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@pitayapj
Copy link
Contributor Author

Exemption Request: comment to prevent automate closing PR

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels May 26, 2025
@alvazjor alvazjor self-assigned this Jun 5, 2025
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@alvazjor alvazjor removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 6, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 6, 2025
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 7, 2025
Copy link
Contributor

github-actions bot commented Jun 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants