Skip to content

Conversation

HeNeos
Copy link
Contributor

@HeNeos HeNeos commented Apr 14, 2025

Issue # (if applicable)

Closes #32791 .

Reason for this change

Keep concordence in arguments for cloudformation and cdk for the state parallel: https://docs.aws.amazon.com/step-functions/latest/dg/state-parallel.html

Description of changes

Add parameters to ParallelJsonPathOptions for ParallelProps.

Describe any new or updated permissions being added

None

Description of how you validated changes

Existing tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 14, 2025 00:28
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 14, 2025
@HeNeos HeNeos changed the title add parameters to parallel state Add parameters to parallel state Apr 14, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@HeNeos HeNeos changed the title Add parameters to parallel state feat(sfn): Add parameters to parallel state Apr 14, 2025
@HeNeos HeNeos changed the title feat(sfn): Add parameters to parallel state feat(sfn): add parameters to parallel state Apr 14, 2025
@HeNeos HeNeos changed the title feat(sfn): add parameters to parallel state feat(stepfunctions): add parameters to parallel state Apr 14, 2025
@HeNeos
Copy link
Contributor Author

HeNeos commented Apr 14, 2025

Exemption Request: Only added Parameters to Parallel state

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 14, 2025
@shikha372 shikha372 self-assigned this Apr 15, 2025
shikha372
shikha372 previously approved these changes Apr 22, 2025
Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HeNeos for contributing this PR, though its a small change it seems to be an important feature that can be modify the attributes being pass to step-functions, i would suggest adding tests and Readme for this feature request.

@shikha372 shikha372 dismissed their stale review April 22, 2025 00:00

by mistake

Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HeNeos for contributing this PR, though its a small change it seems to be an important feature that can be modify the attributes being pass to step-functions, i would suggest adding tests and Readme for this feature request.

@shikha372 shikha372 removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 22, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 22, 2025
@HeNeos HeNeos requested a review from shikha372 May 5, 2025 16:49
Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aws-cdk-automation aws-cdk-automation dismissed their stale review May 10, 2025 23:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@HeNeos HeNeos requested a review from shikha372 May 10, 2025 23:59
@mergify mergify bot dismissed shikha372’s stale review May 11, 2025 01:57

Pull request has been modified.

shikha372
shikha372 previously approved these changes May 12, 2025
Copy link
Contributor

mergify bot commented May 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

Copy link
Contributor

mergify bot commented May 13, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed shikha372’s stale review May 13, 2025 00:41

Pull request has been modified.

@HeNeos
Copy link
Contributor Author

HeNeos commented May 13, 2025

@shikha372 could you approve it again? I have merged main to my fork.

@HeNeos HeNeos requested a review from shikha372 May 13, 2025 03:25
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving as @shikha372 has approved the changes already.

Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9c4462b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0f71ee1 into aws:main May 13, 2025
10 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stepfunctions parallel state don’t support parameters
4 participants