-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(stepfunctions): add parameters to parallel state #34131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Exemption Request: Only added Parameters to Parallel state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HeNeos for contributing this PR, though its a small change it seems to be an important feature that can be modify the attributes being pass to step-functions, i would suggest adding tests and Readme for this feature request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HeNeos for contributing this PR, though its a small change it seems to be an important feature that can be modify the attributes being pass to step-functions, i would suggest adding tests and Readme for this feature request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @HeNeos for adding tests, can we also add some detail to README for this https://github.com/HeNeos/aws-cdk/blob/feat-32791/packages/aws-cdk-lib/aws-stepfunctions/README.md
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
@shikha372 could you approve it again? I have merged main to my fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving as @shikha372 has approved the changes already.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32791 .
Reason for this change
Keep concordence in arguments for cloudformation and cdk for the state parallel: https://docs.aws.amazon.com/step-functions/latest/dg/state-parallel.html
Description of changes
Add parameters to
ParallelJsonPathOptions
forParallelProps
.Describe any new or updated permissions being added
None
Description of how you validated changes
Existing tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license