feat(s3): add replicationRole property to s3.Bucket #34104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new property, `replicationRole`, to the `aws-s3.Bucket` constructor which allows the developer to specify a role to be used for replication. This is required to support the cross-stack scenario for cross-region and cross-account use cases. Tested with included unit and integration tests.
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Apr 10, 2025
hstern
changed the title
hstern
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
It looks like a PR with the same content (#33978 ) has already been submitted and has received maintainer approval. |
hstern
changed the title
|
Thanks. I'll offer a commit to that PR that tests the cross-stack use case. |
1 task
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
#30966 introduced a new feature that allows the developer to configure replication on S3 Buckets. It created the replication role in the source bucket which causes a circular dependency where the destination bucket must exist prior to creating the source bucket, but the source bucket creates the role to which the destination bucket will grant permissions.
Description of changes
This adds a new property,
replicationRole, to theaws-s3.Bucketconstructor which allows the developer to specify a role to be used for replication. This is required to support the cross-stack scenario for cross-region and cross-account use cases.Describe any new or updated permissions being added
No new permissions are required.
Description of how you validated changes
Modified an existing unit test where this fit and created a new integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license