fix(ec2-alpha): add multiple NATGW to the VPC using addNatGateway method #34094
Conversation
shikha372
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
BREAKING CHANGE: The logical ID for the NAT Gateway, defined using the |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
| @@ -451,7 +451,7 @@ export class NatGateway extends Resource implements IRouteTarget { | |||
| if (this.connectivityType === NatConnectivityType.PUBLIC) { | |||
| if (!props.allocationId) { | |||
| let eip = new CfnEIP(this, 'EIP', { | |||
| domain: props.vpc?.vpcId, | |||
| domain: 'vpc', | |||
There was a problem hiding this comment.
Why are we making this change?
There was a problem hiding this comment.
The only allowed values for this field is vpc | standard https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-eip.html#cfn-ec2-eip-address`
This was mistakenly added as vpcID initially, confirmed with @Leo10Gama .
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34094 +/- ##
=======================================
Coverage 84.00% 84.00%
=======================================
Files 121 121
Lines 6984 6984
Branches 1179 1179
=======================================
Hits 5867 5867
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Closes #.
Reason for this change
Cannot add multiple NATGW to current VPC construct as it is using the same construct id which cause conflict.
Description of changes
vpcinstead ofvpcId.Describe any new or updated permissions being added
NA
Description of how you validated changes
Checklist
BREAKING CHANGE: The logical ID for the NAT Gateway, defined using the
addNatGatewaysmethod, will be changed, resulting in the NAT Gateway being recreated. Additionally, the domain for the Elastic IP (EIP) will be set tovpc, which will also trigger its recreation in the account.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license