Skip to content

Conversation

hwum
Copy link
Contributor

@hwum hwum commented Apr 1, 2025

Issue # 33995

#33995
Closes #33995

Reason for this change

Support v2 pipeline type in cdk.pipelines

Description of changes

add pipeline v2 type support

Describe any new or updated permissions being added

new

Description of how you validated changes

integ test/unit test/local deployment

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Apr 1, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 1, 2025 18:43
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Apr 1, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@hwum hwum changed the title feat(pipelines):support v2 pipeline type in L3 construct feat(pipelines):support v2 pipeline in L3 construct Apr 1, 2025
@hwum hwum requested a review from aws-cdk-automation April 1, 2025 18:45
@hwum hwum changed the title feat(pipelines):support v2 pipeline in L3 construct perf(pipelines):support v2 pipeline in L3 construct Apr 1, 2025
@hwum hwum changed the title perf(pipelines):support v2 pipeline in L3 construct feat(pipelines):support v2 pipeline in L3 construct Apr 1, 2025
@hwum hwum changed the title feat(pipelines):support v2 pipeline in L3 construct feat(pipelines): add V2 pipeline type support in L3 construct Apr 1, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 1, 2025 18:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (4db2abd) to head (a91340e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34005   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 1, 2025
@hwum hwum requested a review from rix0rrr April 3, 2025 01:45
Copy link
Contributor

mergify bot commented Apr 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a91340e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 994e952 into aws:main Apr 4, 2025
20 checks passed
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2025
@hwum hwum deleted the l3 branch April 4, 2025 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(pipelines): Support for Code Pipeline V2
3 participants