Skip to content

Conversation

xuxey
Copy link
Contributor

@xuxey xuxey commented Feb 27, 2025

Reason for this change

This adds an alpha module @aws-cdk/aws-s3tables-alpha containing L2 constructs for Amazon S3 Tables.

Description of changes

Amazon S3 Tables deliver the first cloud object store with built-in Apache Iceberg support and streamline storing tabular data at scale. See product page.

These changes set up an alpha module for higher level L2 constructs for S3 Tables:

Example Usage

Define an S3 Table Bucket

// Build a Table bucket
const tableBucket = new TableBucket(scope, 'ExampleTableBucket', {
    tableBucketName: 'example-bucket-1',
    // optional fields:
    unreferencedFileRemoval: {
        noncurrentDays: 123,
        status: 'Enabled',
        unreferencedDays: 123,
    },
});

  // Add resource policy statements
const permissions = new iam.PolicyStatement({
    effect: Effect.ALLOW,
    actions: ['s3tables:*'],
    principals: [ new iam.ServicePrincipal('example.awsamazon.com') ],
    resources: ['*']
});

tableBucket.addResourcePolicy(permissions);

Future constructs are planned to be supported incrementally.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit tests for all major code branches and snapshot integration tests have been added

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 27, 2025 00:46
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@xuxey xuxey changed the title Add L2 constructs for Amazon S3 Tables feat: Add L2 constructs for Amazon S3 Tables Feb 27, 2025
@xuxey xuxey changed the title feat: Add L2 constructs for Amazon S3 Tables feat: support L2 constructs for Amazon S3 Tables Feb 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 5, 2025 19:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@xuxey xuxey marked this pull request as ready for review March 5, 2025 20:00
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 5, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (3de0818) to head (10616f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33599   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         120      120           
  Lines        6933     6933           
  Branches     1169     1169           
=======================================
  Hits         5711     5711           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.37% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SimonCMoore SimonCMoore added p1 and removed p2 labels Mar 11, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 11, 2025
@godwingrs22 godwingrs22 self-assigned this Mar 12, 2025
Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuxey for the great work on the TableBucket and TableBucketPolicy L2 constructs. Left some feedback and suggestions around adding permissions with grant methods to align with the CDK pattern.

@mergify mergify bot dismissed godwingrs22’s stale review March 18, 2025 23:40

Pull request has been modified.

@mergify mergify bot dismissed godwingrs22’s stale review March 26, 2025 00:01

Pull request has been modified.

@mergify mergify bot dismissed godwingrs22’s stale review March 31, 2025 17:34

Pull request has been modified.

Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuxey for the great work. LGTM overall. Currently pending with security review. Will let you incase if there is anything we need to change from security prespective.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dc2233b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuxey for the great work. Looking forward to seeing this construct being used by customers with Amazon S3 Tables. Excited about the launch!

Copy link
Contributor

mergify bot commented Apr 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2e95252 into aws:main Apr 8, 2025
14 checks passed
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants