Skip to content

Conversation

mrlikl
Copy link
Contributor

@mrlikl mrlikl commented Feb 26, 2025

Issue # (if applicable)

Closes #30792

Reason for this change

The feature enables support to create clusters without the default networking add-ons

Description of changes

Describe any new or updated permissions being added

Added the prop bootstrapSelfManagedAddons to the cluster and incremented the eks client version. Also validated that existing if bootstrapSelfManagedAddons is undefined to true or vice versa does not replace the cluster as the default is true.

Description of how you validated changes

Validated the changes against an existing cluster and made sure it is not replaced unless the change is from true to false or vice versa.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrlikl mrlikl marked this pull request as draft February 26, 2025 19:58
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Feb 26, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 26, 2025 19:58
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Feb 26, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (5eeee75) to head (1a6916f).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33597   +/-   ##
=======================================
  Coverage   82.20%   82.21%           
=======================================
  Files         119      119           
  Lines        6862     6876   +14     
  Branches     1158     1162    +4     
=======================================
+ Hits         5641     5653   +12     
- Misses       1118     1120    +2     
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (+<0.01%) ⬆️

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 27, 2025 07:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrlikl mrlikl marked this pull request as ready for review February 27, 2025 13:03
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 27, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrlikl , thank you for your contribution!

Your commits include lots of integ and snapshots changes that aren't necessary and are out of date. You might need to reset your snapshot and integ test changes, then rebase your changes from main.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file are no longer needed due to the following commit: test(eks): remove eks.KubernetesVersion.V1_24 as default version in i…

@Abogical Abogical self-assigned this Jun 2, 2025
@mergify mergify bot dismissed Abogical’s stale review June 2, 2025 12:46

Pull request has been modified.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Abogical Abogical added the pr-linter/no-exemption The requested exemption will not be granted to the PR linter result label Jun 3, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reported by the linter, an integration test would need to be changed or added which would use the new bootstrapSelfManagedAddons property.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 4, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have updated the snapshots, but no integ tests (integ-*.ts) were modified.

@mrlikl
Copy link
Contributor Author

mrlikl commented Jun 5, 2025

I am on it,

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 5, 2025 20:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed Abogical’s stale review June 6, 2025 03:54

Pull request has been modified.

mrlikl added 6 commits June 6, 2025 09:28
- Remove integ.bucket-deployment-signcontent.js and .d.ts files
- These are compiled outputs that should be generated from .ts source
- Follows .gitignore rules that exclude *.js files
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do inline comments as the Files Changed tab doesn't work due to the huge amount of files changed. Apologies for inconvenience.

On cluster.ts:

const compareUndefinedOrTrue = (val1: boolean | undefined, val2: boolean | undefined): boolean => {
    // If both are undefined or true, or one is undefined and the other is true, consider them equal
    if ((val1 === undefined && val2 === true) || (val1 === true && val2 === undefined) || val1 === val2) {
      return true;
    }
    return false;
  };

Replace with

const compareUndefinedOrTrue = (val1: boolean | undefined, val2: boolean | undefined): boolean => {
  return (val1 ?? true) == (val2 ?? true)
}

On packages/@aws-cdk-testing/framework-integ/test/aws-s3-deployment/test/integ.bucket-deployment-signcontent.js:

const app = new cdk.App({
    postCliContext: {
        '@aws-cdk/aws-lambda:useCdkManagedLogGroup': false,
    },
});

Is it necessary to add this option?

On packages/aws-cdk-lib/aws-eks/README.md, replace:

### Self-Managed AddOns

with

### Self-Managed Add-ons

@mergify mergify bot dismissed Abogical’s stale review June 6, 2025 13:34

Pull request has been modified.

@mrlikl
Copy link
Contributor Author

mrlikl commented Jun 6, 2025

The changes are in for review

Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

mergify bot commented Jun 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7fc8778
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jun 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cedc1b0 into aws:main Jun 6, 2025
15 of 16 checks passed
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/no-exemption The requested exemption will not be granted to the PR linter result repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Support for BootstrapSelfManagedAddons while creating the cluster
3 participants