Skip to content

chore(lambda-nodejs): set default value of awsSdkConnectionReuse to false (under feature flag) #29538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

chore(lambda-nodejs): set default value of awsSdkConnectionReuse to false (under feature flag) #29538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
96da1cf
feat: add feature flag
badmintoncryer Mar 19, 2024
a5c8650
test: add unit test
badmintoncryer Mar 19, 2024
710d238
chore: refactor
badmintoncryer Mar 19, 2024
2e96106
test: update integ test
badmintoncryer Mar 19, 2024
4fd1b8b
test: update existing integ test
badmintoncryer Mar 20, 2024
5de1cd8
refactor: integ test
badmintoncryer Mar 20, 2024
f51ff2d
fix: kinesis integ test
badmintoncryer Mar 20, 2024
1c8f84c
test: update integ test
badmintoncryer Mar 20, 2024
6e42eb4
fix: existing integ test
badmintoncryer Mar 21, 2024
a2d9d25
refactor
badmintoncryer Mar 21, 2024
64b5654
Merge branch 'main' into 29497
badmintoncryer Mar 21, 2024
4b74c31
Merge branch 'main' into 29497
badmintoncryer Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.compilations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class TestStack extends Stack {
preCompilation: true,
},
runtime: STANDARD_NODEJS_RUNTIME,
awsSdkConnectionReuse: true,
});

new lambda.NodejsFunction(this, 'ts-decorator-handler-tsconfig', {
Expand All @@ -29,6 +30,7 @@ class TestStack extends Stack {
preCompilation: true,
},
runtime: STANDARD_NODEJS_RUNTIME,
awsSdkConnectionReuse: true,
});
}
}
Expand Down
1 change: 1 addition & 0 deletions ...s/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.dependencies-pnpm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const handler = new lambda.NodejsFunction(stack, 'Function', {
forceDockerBundling: true,
},
depsLockFilePath: path.join(__dirname, 'integ-handlers/pnpm/pnpm-lock.yaml'),
awsSdkConnectionReuse: true,
});

const integ = new IntegTest(app, 'PnpmTest', {
Expand Down
3 changes: 3 additions & 0 deletions packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class SdkV2TestStack extends Stack {
this.lambdaFunction = new lambda.NodejsFunction(this, 'external', {
entry: path.join(__dirname, 'integ-handlers/dependencies.ts'),
runtime: STANDARD_NODEJS_RUNTIME,
awsSdkConnectionReuse: true,
bundling: {
minify: true,
// Will be installed, not bundled
Expand All @@ -39,6 +40,7 @@ class SdkV3TestStack extends Stack {
this.lambdaFunction = new lambda.NodejsFunction(this, 'external-sdk-v3', {
entry: path.join(__dirname, 'integ-handlers/dependencies-sdk-v3.ts'),
runtime: Runtime.NODEJS_18_X,
awsSdkConnectionReuse: true,
});
}
}
Expand All @@ -53,6 +55,7 @@ class SdkV3BundledStack extends Stack {
this.lambdaFunction = new lambda.NodejsFunction(this, 'bundle-sdk', {
entry: path.join(__dirname, 'integ-handlers/dependencies-sdk-v3.ts'),
runtime: Runtime.NODEJS_18_X,
awsSdkConnectionReuse: true,
bundling: {
bundleAwsSDK: true,
},
Expand Down
1 change: 1 addition & 0 deletions packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.esbuildArgs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class TestStack extends Stack {
new lambda.NodejsFunction(this, 'ts-handler', {
entry: path.join(__dirname, 'integ-handlers/ts-handler.ts'),
runtime: STANDARD_NODEJS_RUNTIME,
awsSdkConnectionReuse: true,
bundling: {
minify: true,
sourceMap: true,
Expand Down
1 change: 1 addition & 0 deletions packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.esm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class TestStack extends Stack {

new lambda.NodejsFunction(this, 'esm', {
entry: path.join(__dirname, 'integ-handlers/esm.ts'),
awsSdkConnectionReuse: true,
bundling: {
format: lambda.OutputFormat.ESM,
},
Expand Down
2 changes: 2 additions & 0 deletions ....snapshot/asset.5017e4b2e278e32bc634202d075b7ed8961b0d784f75450f7918a6a4f6f7df4a/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions ...pshot/asset.5017e4b2e278e32bc634202d075b7ed8961b0d784f75450f7918a6a4f6f7df4a/index.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions ....snapshot/asset.5fd5332ac0f100f1845842d79d110a7cf0957bd31419a7aabaedf8d3043ddf09/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions ....snapshot/asset.6c52cc5df44f0d18474ce4399377d62ee08c9b9cb11855fb95070dcd83a5a6ea/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions ....snapshot/asset.e13d2f4e26b1586fe7e2b9f1ce013083dfee5fffc377061fa1489449fd8b0cc8/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions ...pshot/asset.e13d2f4e26b1586fe7e2b9f1ce013083dfee5fffc377061fa1489449fd8b0cc8/index.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions ...shot/asset.e13d2f4e26b1586fe7e2b9f1ce013083dfee5fffc377061fa1489449fd8b0cc8/ts-web-run.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

71 changes: 71 additions & 0 deletions ...tion-reuse.js.snapshot/cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 15 additions & 15 deletions ...hot/cdk-integ-lambda-nodejs.template.json → ...-sdk-connection-reuse-stack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc"
}
]
}
Expand Down Expand Up @@ -213,7 +213,7 @@
},
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet1"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet1"
}
],
"VpcId": {
Expand All @@ -227,7 +227,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet1"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet1"
}
],
"VpcId": {
Expand Down Expand Up @@ -268,7 +268,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet1"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet1"
}
]
}
Expand All @@ -288,7 +288,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet1"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet1"
}
]
},
Expand Down Expand Up @@ -321,7 +321,7 @@
},
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet2"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet2"
}
],
"VpcId": {
Expand All @@ -335,7 +335,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet2"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet2"
}
],
"VpcId": {
Expand Down Expand Up @@ -376,7 +376,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet2"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet2"
}
]
}
Expand All @@ -396,7 +396,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PublicSubnet2"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PublicSubnet2"
}
]
},
Expand Down Expand Up @@ -429,7 +429,7 @@
},
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PrivateSubnet1"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PrivateSubnet1"
}
],
"VpcId": {
Expand All @@ -443,7 +443,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PrivateSubnet1"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PrivateSubnet1"
}
],
"VpcId": {
Expand Down Expand Up @@ -498,7 +498,7 @@
},
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PrivateSubnet2"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PrivateSubnet2"
}
],
"VpcId": {
Expand All @@ -512,7 +512,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc/PrivateSubnet2"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc/PrivateSubnet2"
}
],
"VpcId": {
Expand Down Expand Up @@ -549,7 +549,7 @@
"Tags": [
{
"Key": "Name",
"Value": "cdk-integ-lambda-nodejs/Vpc"
"Value": "cdk-integ-lambda-nodejs-aws-sdk-connection-reuse-stack/Vpc"
}
]
}
Expand Down Expand Up @@ -617,7 +617,7 @@
"tshandlervpcSecurityGroup587CC215": {
"Type": "AWS::EC2::SecurityGroup",
"Properties": {
"GroupDescription": "Automatic security group for Lambda Function cdkinteglambdanodejstshandlervpcAAE6104A",
"GroupDescription": "Automatic security group for Lambda Function cdkinteglambdanodejsawssdkconnectionreusestacktshandlervpcFBB4366A",
"SecurityGroupEgress": [
{
"CidrIp": "0.0.0.0/0",
Expand Down
1 change: 1 addition & 0 deletions ...g/test/aws-lambda-nodejs/test/integ.function-aws-sdk-connection-reuse.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading