chore: build.sh script requires lerna to be globally installed #24556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Closing since this was already done in #24217! Thanks @timmattison! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up a new laptop, I realized that our build scripts require a global installation of
lerna, but the contributing guide does not actually tell you to install it.The
build.shscript runs thelernacommand directly, which only works iflernais globally installed.lernais a dependency in the monorepo, which means after ayarn install,lernais available in the monorepo, and a global install is not necessary. This PR changes build.sh to runnpx lernaso that a global install is not required to run the build.sh script.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license