Skip to content

Conversation

corymhall
Copy link
Contributor

If you were not applying a permissions boundary at all (previously or currently) then you would get a message like Switching from to undefined.... This PR fixes that and updates the wording a little.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

If you were not applying a permissions boundary at all (previously or
currently) then you would get a message like `Switching from  to
undefined...`. This PR fixes that and updates the wording a little.
@github-actions github-actions bot added the p2 label Feb 27, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 27, 2023 14:42
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 27, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Feb 27, 2023
@corymhall corymhall added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Feb 27, 2023
@corymhall
Copy link
Contributor Author

Ran it through the test pipeline and the only failure was in the go init tests (ongoing issue)

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 27, 2023 16:02

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Feb 27, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the above please, then good to go

@corymhall corymhall removed the pr/do-not-merge This PR should not be merged at this time. label Feb 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e06d5e9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5aadf2a into aws:main Feb 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

westhouseK pushed a commit to westhouseK/aws-cdk that referenced this pull request Feb 28, 2023
)

If you were not applying a permissions boundary at all (previously or currently) then you would get a message like `Switching from  to undefined...`. This PR fixes that and updates the wording a little.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
)

If you were not applying a permissions boundary at all (previously or currently) then you would get a message like `Switching from  to undefined...`. This PR fixes that and updates the wording a little.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants