-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore(bootstrap): improve permissions boundary switch message #24354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you were not applying a permissions boundary at all (previously or currently) then you would get a message like `Switching from to undefined...`. This PR fixes that and updates the wording a little.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Ran it through the test pipeline and the only failure was in the go init tests (ongoing issue) |
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the above please, then good to go
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
) If you were not applying a permissions boundary at all (previously or currently) then you would get a message like `Switching from to undefined...`. This PR fixes that and updates the wording a little. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
) If you were not applying a permissions boundary at all (previously or currently) then you would get a message like `Switching from to undefined...`. This PR fixes that and updates the wording a little. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
If you were not applying a permissions boundary at all (previously or currently) then you would get a message like
Switching from to undefined...
. This PR fixes that and updates the wording a little.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license