chore(yarn-cling): breaks on dependency cycle #18188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent upgrade, one of our dependencies (
json-diff
) has takena dependency on a cluster of packages that have dependency cycles
between them. Specifically:
yarn-cling
used to go into infinite recursion trying to resolve thisdependency tree, as it was not prepared to handle cycles.
Add a dependency breaker. Since I wasn't sure whether or not this
might break the dependency tree, add a validation step as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license