(aws-autoscaling): Missing KeyPair field on autoScalingGroupProps

[Brads3290]

Describe the bug

Using the KeyName to specify a key pair will be deprecated on the launchTemplateProps construct.

When using KeyName on autoScalingGroupProps, CDK gives the following warning on synth:

[WARNING] aws-cdk-lib.aws_ec2.LaunchTemplateProps#keyName is deprecated.
  - Use `keyPair` instead - https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2-readme.html#using-an-existing-ec2-key-pair
  This API will be removed in the next major release.

Presumably autoScalingGroupProps uses launchTemplateProps underneath. autoScalingGroupProps should have a KeyPair property that is passed to the underlying launchTemplateProps.

Expected Behavior

autoScalingGroupProps should have a KeyPair property that is passed to the underlying launchTemplateProps.

Current Behavior

[WARNING] aws-cdk-lib.aws_ec2.LaunchTemplateProps#keyName is deprecated.
  - Use `keyPair` instead - https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2-readme.html#using-an-existing-ec2-key-pair
  This API will be removed in the next major release.

Reproduction Steps

var asg = new AutoScalingGroup(this, "Asg", new AutoScalingGroupProps() {
    Vpc = props.Vpc,
    VpcSubnets = new SubnetSelection() {
        AvailabilityZones = props.AvailabilityZone is not null
            ? new[] { props.AvailabilityZone }
            : null,
    },
    InstanceType = InstanceType.Of(InstanceClass.T3A, InstanceSize.MEDIUM),
    MachineImage = EcsOptimizedImage.AmazonLinux2023(),
    SecurityGroup = instanceSg,
    KeyName = props.Ec2KeyPair, // <-- This
});

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.129.0 (build d5ab0df)

Framework Version

No response

Node.js Version

v18.16.1

OS

MacOS

Language

.NET

Language Version

No response

Other information

No response

[pahud]

Yes, as AutoScaling is using LaunchTemplate L2 to create the launch template when feature flag is enabled:

aws-cdk/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts

Line 1373 in f3d74bb

keyName: props.keyName,

I think we should follow the convention as here

aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/launch-template.ts

Line 758 in f3d74bb

keyName: props.keyPair?.keyPairName ?? props?.keyName,

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.