Skip to content

(appconfig): Linter errors must be audited #27894

@kaizencc

Description

@kaizencc

Describe the bug

AppConfig L2 in alpha stage was released without the linter checker turned on, so none of these linter exceptions have been audited. These rules likely should be fixed rather than exempted, which could result in breaking changes. Marking this as a p1 because this issue should block any potential graduation of the AppConfig module.

As seen in the awslint.json file:

{
        "no-unused-type:@aws-cdk/aws-appconfig-alpha.PredefinedDeploymentStrategyId",
        "ref-via-interface:@aws-cdk/aws-appconfig-alpha.Application.addAgentToEcs.taskDef",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.ApplicationProps",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.DeploymentStrategyProps",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.EnvironmentProps",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.ExtensionProps",
        "events-in-interface",
        "events-method-signature",
        "events-generic"
}

Expected Behavior

No linter errors

Current Behavior

Linter rules are being exempted

Reproduction Steps

n/a

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.100.0

Framework Version

No response

Node.js Version

20

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    @aws-cdk/aws-appconfigRelated to AWS AppConfigbugThis issue is a bug.effort/smallSmall work item – less than a day of effortp1

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions