-
Notifications
You must be signed in to change notification settings - Fork 39
fix(cli): logs entire environment #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can make this change in a way that the next person working on this code doesn't see the double env assignment and "optimizes" it away? Thus creating a regression?
A test case would help. Or variable naming maybe or moving process.env
into the writeContextToEnv
helper.
fc9e319
to
4f22974
Compare
I did both. |
Right now the CLI logs the entire environment to debug logging. This is a lot of data, and potentially also includes tokens we'd rather don't end up in logging. Instead, just log our additions to the existing environment.
4f22974
to
ae81dc0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 79.03% 79.01% -0.03%
==========================================
Files 46 46
Lines 7092 7085 -7
Branches 791 791
==========================================
- Hits 5605 5598 -7
Misses 1468 1468
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Right now the CLI logs the entire environment to debug logging. This is a lot of data, and potentially also includes tokens we'd rather don't end up in logging.
Instead, just log our additions to the existing environment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license