-
Notifications
You must be signed in to change notification settings - Fork 35
feat(toolkit-lib)!: support custom https.Agent
for SDK requests
#533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aws-cdk-automation
merged 3 commits into
main
from
mrgrain/feat/toolkit-lib/https-agents
May 27, 2025
Merged
feat(toolkit-lib)!: support custom https.Agent
for SDK requests
#533
aws-cdk-automation
merged 3 commits into
main
from
mrgrain/feat/toolkit-lib/https-agents
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0659625
to
fd9a54c
Compare
65a83db
to
8c32dd1
Compare
fd9a54c
to
4fe8dc6
Compare
8c32dd1
to
6aa8b19
Compare
rix0rrr
approved these changes
May 26, 2025
6aa8b19
to
4d1903c
Compare
Base automatically changed from
mrgrain/chore/integ-workflow/update-verdaccio-config
to
main
May 27, 2025 07:02
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
- Coverage 79.01% 78.88% -0.13%
==========================================
Files 47 47
Lines 7032 7032
Branches 786 781 -5
==========================================
- Hits 5556 5547 -9
- Misses 1458 1467 +9
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398
Depends on #532
Previously automatically configured the SDK to pass all requests through an instance of
ProxyAgent
from the third-partyproxy-agent
package. A user could configure its proxy settings, but by default it would act as a pass through.proxy-agent
is a hefty dependency (primarily due to its support forpac
files) that not everyone might want to use. This is the standard interface in Node.js and we are aligning on it.Note that with this we are also removing built-in (but not advertised) support for managing proxy configuration through env vars like
HTTP_PROXY
orHTTPS_PROXY
. This functionality was provided byproxy-agent
and the easiest way to get it back is by configuringproxy-agent
again.BREAKING CHANGE: Dependency on
proxy-agent
has been removed, this also removes the support of configuring a proxy through likeHTTPS_PROXY
andAWS_CA_BUNDLE
. The type ofsdkConfig.httpOptions
has changed to now optionally take a singleagent: https.Agent
property instead of the proxy settings. The restore the previous behavior, pass an instance ofProxyAgent
tosdkConfig.httpOptions
:{ agent: new ProxyAgent({ ca: oldHttpOptions.caBundlePath, getProxyForUrl: () => oldHttpOptions.proxyAddress }) }
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license